chore: raise MSRV and toolchain to 1.86#227
Closed
sksat (sksat) wants to merge 1 commit into
Closed
Conversation
The url 2.5.x update (#121) pulls idna 1.x, whose icu_* 2.2.0 stack declares rust-version 1.86 — one minor above the 1.85 floor we just set. Raise rust-version and the pinned toolchain to 1.86 (April 2025) to unblock it, keeping the dev/CI toolchain and the MSRV coupled. Verified locally with cargo 1.86.0: cargo check --workspace --all-targets --locked cargo fmt --all --check Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded by #229, which raised the MSRV to 1.88 (required by cargo-about 0.9 now that notalawyer-build 0.3 pulls it in as a library build-dependency). main is already at 1.88, so this 1.86 bump is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cargo.tomlrust-versionrust-toolchainchannelWhy
Follow-up to #223. The url 2.5.x update (#121) pulls
idna 1.x, whoseicu_*2.2.0 stack declaresrust-version = 1.86:One minor short of the 1.85 floor set this morning. 1.86 (April 2025) is still a conservative floor. The cargo-about 0.9 requirement (rustc 1.88) is handled separately by decoupling the tool install from the toolchain (#226), so the MSRV does not need to chase CI tools.
Verification
Locally under
cargo 1.86.0:cargo check --workspace --all-targets --lockedandcargo fmt --all --checkboth pass.Follow-up
🤖 Generated with Claude Code